mirror of
https://github.com/leonvanzyl/autocoder.git
synced 2026-01-30 06:12:06 +00:00
feat(security): add audit logging for shlex fallback parser
- Add debug logging when shlex fallback extraction is used, capturing both successful extractions and failures for security auditing - Add test case for docker nested quotes that trigger fallback parser - Remove redundant comment about re import (already at module level) Follow-up improvements from PR #127 code review: - Enables tracking of malformed command patterns in production logs - Verifies fallback parser handles the exact docker exec case reported Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
15
security.py
15
security.py
@@ -6,6 +6,7 @@ Pre-tool-use hooks that validate bash commands for security.
|
||||
Uses an allowlist approach - only explicitly permitted commands can run.
|
||||
"""
|
||||
|
||||
import logging
|
||||
import os
|
||||
import re
|
||||
import shlex
|
||||
@@ -14,6 +15,9 @@ from typing import Optional
|
||||
|
||||
import yaml
|
||||
|
||||
# Logger for security-related events (fallback parsing, validation failures, etc.)
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
# Regex pattern for valid pkill process names (no regex metacharacters allowed)
|
||||
# Matches alphanumeric names with dots, underscores, and hyphens
|
||||
VALID_PROCESS_NAME_PATTERN = re.compile(r"^[A-Za-z0-9._-]+$")
|
||||
@@ -195,7 +199,6 @@ def extract_commands(command_string: str) -> list[str]:
|
||||
commands = []
|
||||
|
||||
# shlex doesn't treat ; as a separator, so we need to pre-process
|
||||
# (re is already imported at module level)
|
||||
|
||||
# Split on semicolons that aren't inside quotes (simple heuristic)
|
||||
# This handles common cases like "echo hello; ls"
|
||||
@@ -213,7 +216,17 @@ def extract_commands(command_string: str) -> list[str]:
|
||||
# Try fallback extraction instead of blocking entirely
|
||||
fallback_cmd = _extract_primary_command(segment)
|
||||
if fallback_cmd:
|
||||
logger.debug(
|
||||
"shlex fallback used: segment=%r -> command=%r",
|
||||
segment,
|
||||
fallback_cmd,
|
||||
)
|
||||
commands.append(fallback_cmd)
|
||||
else:
|
||||
logger.debug(
|
||||
"shlex fallback failed: segment=%r (no command extracted)",
|
||||
segment,
|
||||
)
|
||||
continue
|
||||
|
||||
if not tokens:
|
||||
|
||||
Reference in New Issue
Block a user