From 4336252b30edb2625199232ed64424f01e3f9ece Mon Sep 17 00:00:00 2001 From: chrislangston Date: Sat, 31 Jan 2026 11:22:19 -0500 Subject: [PATCH] fix: guard against empty/whitespace ANTHROPIC_DEFAULT_OPUS_MODEL values Trim the env var value and fall back to the default model when the trimmed result is empty. This prevents invalid empty strings from being appended to VALID_MODELS. Addresses CodeRabbit review feedback on PR #147. --- registry.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/registry.py b/registry.py index f53e8bd..cd52c7b 100644 --- a/registry.py +++ b/registry.py @@ -40,11 +40,15 @@ VALID_MODELS = [m["id"] for m in AVAILABLE_MODELS] # Default model and settings # Respect ANTHROPIC_DEFAULT_OPUS_MODEL env var for Foundry/custom deployments -DEFAULT_MODEL = os.getenv("ANTHROPIC_DEFAULT_OPUS_MODEL", "claude-opus-4-5-20251101") +# Guard against empty/whitespace values by trimming and falling back when blank +_env_default_model = os.getenv("ANTHROPIC_DEFAULT_OPUS_MODEL") +if _env_default_model is not None: + _env_default_model = _env_default_model.strip() +DEFAULT_MODEL = _env_default_model or "claude-opus-4-5-20251101" # Ensure env-provided DEFAULT_MODEL is in VALID_MODELS for validation consistency # (idempotent: only adds if missing, doesn't alter AVAILABLE_MODELS semantics) -if DEFAULT_MODEL not in VALID_MODELS: +if DEFAULT_MODEL and DEFAULT_MODEL not in VALID_MODELS: VALID_MODELS.append(DEFAULT_MODEL) DEFAULT_YOLO_MODE = False