ros/autocoder
1
0
Fork 0
mirror of https://github.com/leonvanzyl/autocoder.git synced 2026-02-01 06:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #130 from ipodishima/fix/too_many_agents_spawned

Browse Source 
fix: prevent runaway testing agent spawning (critical)
This commit is contained in:
Leon van Zyl
2026-01-30 09:03:52 +02:00
committed by GitHub
parent 3edb380b58 80b6af7b2b
commit 21fe28f51d
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
parallel_orchestrator.py
View File

@@ -170,8 +170,9 @@ class ParallelOrchestrator:
self._lock = threading.Lock() self._lock = threading.Lock()
# Coding agents: feature_id -> process # Coding agents: feature_id -> process
self.running_coding_agents: dict[int, subprocess.Popen] = {} self.running_coding_agents: dict[int, subprocess.Popen] = {}
# Testing agents: feature_id -> process (feature being tested) # Testing agents: pid -> (feature_id, process)
self.running_testing_agents: dict[int, subprocess.Popen] = {} # Keyed by PID (not feature_id) because multiple agents can test the same feature
self.running_testing_agents: dict[int, tuple[int, subprocess.Popen]] = {}
# Legacy alias for backward compatibility # Legacy alias for backward compatibility
self.running_agents = self.running_coding_agents self.running_agents = self.running_coding_agents
self.abort_events: dict[int, threading.Event] = {} self.abort_events: dict[int, threading.Event] = {}
@@ -429,7 +430,10 @@ class ParallelOrchestrator:
# Spawn outside lock (I/O bound operation) # Spawn outside lock (I/O bound operation)
print(f"[DEBUG] Spawning testing agent ({spawn_index}/{desired})", flush=True) print(f"[DEBUG] Spawning testing agent ({spawn_index}/{desired})", flush=True)
self._spawn_testing_agent() success, msg = self._spawn_testing_agent()
if not success:
debug_log.log("TESTING", f"Spawn failed, stopping: {msg}")
return
def start_feature(self, feature_id: int, resume: bool = False) -> tuple[bool, str]: def start_feature(self, feature_id: int, resume: bool = False) -> tuple[bool, str]:
"""Start a single coding agent for a feature. """Start a single coding agent for a feature.
@@ -611,8 +615,9 @@ class ParallelOrchestrator:
debug_log.log("TESTING", f"FAILED to spawn testing agent: {e}") debug_log.log("TESTING", f"FAILED to spawn testing agent: {e}")
return False, f"Failed to start testing agent: {e}" return False, f"Failed to start testing agent: {e}"
# Register process with feature ID (same pattern as coding agents) # Register process by PID (not feature_id) to avoid overwrites
self.running_testing_agents[feature_id] = proc # when multiple agents test the same feature
self.running_testing_agents[proc.pid] = (feature_id, proc)
testing_count = len(self.running_testing_agents) testing_count = len(self.running_testing_agents)
# Start output reader thread with feature ID (same as coding agents) # Start output reader thread with feature ID (same as coding agents)
@@ -795,11 +800,8 @@ class ParallelOrchestrator:
""" """
if agent_type == "testing": if agent_type == "testing":
with self._lock: with self._lock:
# Remove from dict by finding the feature_id for this proc # Remove by PID
for fid, p in list(self.running_testing_agents.items()): self.running_testing_agents.pop(proc.pid, None)
if p is proc:
del self.running_testing_agents[fid]
break
status = "completed" if return_code == 0 else "failed" status = "completed" if return_code == 0 else "failed"
print(f"Feature #{feature_id} testing {status}", flush=True) print(f"Feature #{feature_id} testing {status}", flush=True)
@@ -898,9 +900,9 @@ class ParallelOrchestrator:
with self._lock: with self._lock:
testing_items = list(self.running_testing_agents.items()) testing_items = list(self.running_testing_agents.items())
for feature_id, proc in testing_items: for pid, (feature_id, proc) in testing_items:
result = kill_process_tree(proc, timeout=5.0) result = kill_process_tree(proc, timeout=5.0)
debug_log.log("STOP", f"Killed testing agent for feature #{feature_id} (PID {proc.pid})", debug_log.log("STOP", f"Killed testing agent for feature #{feature_id} (PID {pid})",
status=result.status, children_found=result.children_found, status=result.status, children_found=result.children_found,
children_terminated=result.children_terminated, children_killed=result.children_killed) children_terminated=result.children_terminated, children_killed=result.children_killed)