chore: cleaned up bad architecture file calls, legacy doc references, and case sensitivity issues to remove ambiguity (#718)

src/modules/bmm/workflows/4-implementation/create-story/checklist.md

@@ -4,7 +4,7 @@ validation-target: 'Newly generated story markdown file'
 required-inputs:
   - 'epics.md (preferred) or PRD'
 optional-inputs:
-  - 'HLA document for architecture context'
+  - 'solution-architecture document for architecture context'
 validation-rules:
   - 'Story structure matches sections: Status, Story, Acceptance Criteria, Tasks/Subtasks, Dev Notes, Change Log, Dev Agent Record'
   - 'Dev Notes include Project Structure Notes and References subsections'

src/modules/bmm/workflows/4-implementation/create-story/instructions.md

@@ -12,7 +12,7 @@
     <action>Resolve variables from config_source: story_dir (dev_story_location), output_folder, user_name, communication_language. If story_dir missing and {{non_interactive}} == false → ASK user to provide a stories directory and update variable. If {{non_interactive}} == true and missing, HALT with a clear message.</action>
     <action>Create {{story_dir}} if it does not exist</action>
     <action>Resolve installed component paths from workflow.yaml: template, instructions, validation</action>
-    <action>Resolve recommended inputs if present: epics_file, prd_file, hla_file</action>
+    <action>Resolve recommended inputs if present: epics_file, prd_file, solution-architecture_file</action>
   </step>
 
   <step n="2" goal="Discover and load source documents">
@@ -21,7 +21,7 @@
       1) tech_spec_file (epic-scoped)
       2) epics_file (acceptance criteria and breakdown)
       3) prd_file (business requirements and constraints)
-      4) hla_file (architecture constraints)
+      4) solution-architecture_file (architecture constraints)
       5) Architecture docs under docs/ and output_folder/: tech-stack.md, unified-project-structure.md, coding-standards.md, testing-strategy.md, backend-architecture.md, frontend-architecture.md, data-models.md, database-schema.md, rest-api-spec.md, external-apis.md (include if present)
     </action>
     <action>READ COMPLETE FILES for all items found in the prioritized set. Store content and paths for citation.</action>
@@ -42,7 +42,7 @@
 
   <step n="4" goal="Extract requirements and derive story statement">
     <action>From tech_spec_file (preferred) or epics_file: extract epic {{epic_num}} title/summary, acceptance criteria for the next story, and any component references. If not present, fall back to PRD sections mapping to this epic/story.</action>
-    <action>From hla and architecture docs: extract constraints, patterns, component boundaries, and testing guidance relevant to the extracted ACs. ONLY capture information that directly informs implementation of this story.</action>
+    <action>From solution-architecture and architecture docs: extract constraints, patterns, component boundaries, and testing guidance relevant to the extracted ACs. ONLY capture information that directly informs implementation of this story.</action>
     <action>Derive a clear user story statement (role, action, benefit) grounded strictly in the above sources. If ambiguous and {{non_interactive}} == false → ASK user to clarify. If {{non_interactive}} == true → generate the best grounded statement WITHOUT inventing domain facts.</action>
     <template-output file="{default_output_file}">requirements_context_summary</template-output>
   </step>

src/modules/bmm/workflows/4-implementation/create-story/template.md

@@ -38,7 +38,7 @@ so that {{benefit}}.
 
 ### Context Reference
 
-<!-- Path(s) to story context XML/JSON will be added here by context workflow -->
+<!-- Path(s) to story context XML will be added here by context workflow -->
 
 ### Agent Model Used
 

src/modules/bmm/workflows/4-implementation/create-story/workflow.yaml

@@ -19,8 +19,8 @@ validation: "{installed_path}/checklist.md"
 variables:
   story_dir: "{config_source}:dev_story_location" # Directory where stories are stored
   epics_file: "{output_folder}/epics.md" # Preferred source for epic/story breakdown
-  prd_file: "{output_folder}/prd.md" # Fallback for requirements
-  hla_file: "{output_folder}/high-level-architecture.md" # Optional architecture context
+  prd_file: "{output_folder}/PRD.md" # Fallback for requirements
+  solution-architecture_file: "{output_folder}/solution-architecture.md" # Optional architecture context
   tech_spec_file: "" # Will be auto-discovered from docs as tech-spec-epic-{{epic_num}}-*.md
   tech_spec_search_dir: "{project-root}/docs"
   tech_spec_glob_template: "tech-spec-epic-{{epic_num}}*.md"
@@ -28,16 +28,8 @@ variables:
     - "{project-root}/docs"
     - "{output_folder}"
   arch_docs_file_names: |
-    - tech-stack.md
-    - unified-project-structure.md
-    - coding-standards.md
-    - testing-strategy.md
-    - backend-architecture.md
-    - frontend-architecture.md
-    - data-models.md
-    - database-schema.md
-    - rest-api-spec.md
-    - external-apis.md
+    - solution-architecture.md
+    - infrastructure-architecture.md
   story_title: "" # Will be elicited if not derivable
   epic_num: 1
   story_num: 1
@@ -57,9 +49,9 @@ required_tools:
   - glob
 
 recommended_inputs:
-  - epics: "Epic breakdown (epic-list.md)"
+  - epics: "Epic breakdown (epics.md)"
   - prd: "PRD document"
-  - hla: "High-Level Architecture (optional)"
+  - solution-architecture: "Solution Architecture (optional)"
 
 tags:
   - story-generation
@@ -67,8 +59,8 @@ tags:
   - bmad-v6
 
 execution_hints:
-  interactive: false
-  autonomous: true
+  interactive: false # Minimize prompts; intended to run to completion
+  autonomous: true # Proceed without user input unless blocked
   iterative: true
 
 web_bundle: false

src/modules/bmm/workflows/4-implementation/dev-story/workflow.yaml

@@ -24,8 +24,8 @@ variables:
   strict: true # if true, halt on validation failures
   story_dir: "{config_source}:dev_story_location" # Directory containing story markdown files
   story_selection_limit: 10
-  run_until_complete: true # Continue through all tasks without pausing except on HALT conditions
-  force_yolo: true # Hint executor to activate #yolo: skip optional prompts and elicitation
+  run_until_complete: false # Continue through all tasks without pausing except on HALT conditions
+  force_yolo: false # Hint executor to activate #yolo: skip optional prompts and elicitation
 
 # Recommended inputs
 recommended_inputs:

src/modules/bmm/workflows/4-implementation/review-story/workflow.yaml

@@ -34,24 +34,11 @@ variables:
     - "{project-root}/docs"
     - "{output_folder}"
   arch_docs_file_names: |
-    - prd.md
-    - epics.md
-    - high-level-architecture.md
-    - tech-stack.md
-    - unified-project-structure.md
-    - coding-standards.md
-    - testing-strategy.md
-    - security-guidelines.md
-    - backend-architecture.md
-    - frontend-architecture.md
-    - data-models.md
-    - database-schema.md
-    - rest-api-spec.md
-    - external-apis.md
+    - solution-architecture.md
   enable_mcp_doc_search: true # Prefer enabled MCP servers for doc/best-practice lookup
   enable_web_fallback: true # Fallback to web search/read-url if MCP not available
-  update_status_on_result: false # If true, update story Status based on review outcome
-  status_on_approve: "Done"
+  update_status_on_result: true # If true, update story Status based on review outcome
+  status_on_approve: "Review Passed"
   status_on_changes_requested: "InProgress"
   # Persistence controls for review action items and notes
   persist_action_items: true
@@ -71,7 +58,7 @@ variables:
 recommended_inputs:
   - story_markdown: "Path to the story markdown file flagged Ready for Review"
   - tech_spec: "Epic technical specification document (auto-discovered if omitted)"
-  - story_context: "Story Context XML/JSON path (auto-discovered if omitted)"
+  - story_context: "Story Context XML path (auto-discovered if omitted)"
 
 # Required tools (conceptual; executor should provide equivalents)
 required_tools:

src/modules/bmm/workflows/4-implementation/story-context/workflow.yaml

@@ -27,7 +27,7 @@ variables:
   non_interactive: true
 
 # Output configuration
-default_output_file: "{output_folder}/story-context-{{epic_id}}.{{story_id}}.xml"
+default_output_file: "{story_dir}/story-context-{{epic_id}}.{{story_id}}.xml"
 
 # Recommended inputs
 recommended_inputs: