all agents passing new validation checks

test/fixtures/agent-schema/invalid/menu-triggers/compound-mismatched-kebab.agent.yaml

@@ -1,14 +1,14 @@
-# Test: Compound trigger with mismatched kebab portions
+# Test: Compound trigger with old format (no longer supported)
 # Expected: FAIL
 # Error code: custom
 # Error path: agent.menu[0].trigger
-# Error message: agent.menu[].trigger compound format error: kebab-case trigger mismatch: "tech-spec" vs "other-thing"
+# Error message: agent.menu[].trigger compound format error: invalid compound trigger format
 
 agent:
   metadata:
     id: compound-mismatched-kebab
-    name: Mismatched Kebab
-    title: Mismatched Kebab Test
+    name: Old Format
+    title: Old Format Test
     icon: 🧪
 
   persona:
@@ -19,6 +19,6 @@ agent:
       - Test principle
 
   menu:
-    - trigger: TS or tech-spec or fuzzy match on other-thing
-      description: Kebab portions do not match
+    - trigger: TS or tech-spec or fuzzy match on tech-spec
+      description: Old format with middle kebab-case (no longer supported)
       action: test

test/fixtures/agent-schema/invalid/metadata/module-agent-missing-module.agent.yaml

@@ -1,25 +0,0 @@
-# Test: Module agent missing required module field
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.metadata.module
-# Error message: module-scoped agents must declare agent.metadata.module
-# Path context: src/modules/bmm/agents/module-agent-missing-module.agent.yaml
-
-agent:
-  metadata:
-    id: bmm-missing-module
-    name: BMM Missing Module
-    title: Missing Module
-    icon: ❌
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

test/fixtures/agent-schema/invalid/metadata/wrong-module-value.agent.yaml

@@ -1,26 +0,0 @@
-# Test: Module agent with wrong module value
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.metadata.module
-# Error message: agent.metadata.module must equal "bmm"
-# Path context: src/modules/bmm/agents/wrong-module-value.agent.yaml
-
-agent:
-  metadata:
-    id: wrong-module
-    name: Wrong Module
-    title: Wrong Module
-    icon: ❌
-    module: cis
-
-  persona:
-    role: Test agent
-    identity: Test identity
-    communication_style: Test style
-    principles:
-      - Test principle
-
-  menu:
-    - trigger: help
-      description: Show help
-      action: display_help

test/fixtures/agent-schema/valid/menu-triggers/compound-triggers.agent.yaml

@@ -16,15 +16,15 @@ agent:
       - Test compound format
 
   menu:
-    - trigger: TS or tech-spec or fuzzy match on tech-spec
-      description: Two-word compound trigger
+    - trigger: TS or fuzzy match on tech-spec
+      description: "[TS] Two-word compound trigger"
       action: tech_spec
-    - trigger: DS or dev-story or fuzzy match on dev-story
-      description: Another two-word compound trigger
+    - trigger: DS or fuzzy match on dev-story
+      description: "[DS] Another two-word compound trigger"
       action: dev_story
-    - trigger: WI or workflow-init-process or fuzzy match on workflow-init-process
-      description: Three-word compound trigger (uses first 2 words for shortcut)
+    - trigger: WI or fuzzy match on workflow-init-process
+      description: "[WI] Three-word compound trigger (uses first 2 words for shortcut)"
       action: workflow_init
-    - trigger: H or help or fuzzy match on help
-      description: Single-word compound trigger (1-letter shortcut)
+    - trigger: H or fuzzy match on help
+      description: "[H] Single-word compound trigger (1-letter shortcut)"
       action: help

test/fixtures/agent-schema/valid/metadata/core-agent-with-module.agent.yaml

@@ -1,16 +1,13 @@
-# Test: Core agent with unexpected module field
-# Expected: FAIL
-# Error code: custom
-# Error path: agent.metadata.module
-# Error message: core agents must not include agent.metadata.module
-# Path context: src/core/agents/core-agent-with-module.agent.yaml
+# Test: Core agent can have module field
+# Expected: PASS
+# Note: Core agents can now include module field if needed
 
 agent:
   metadata:
     id: core-with-module
     name: Core With Module
     title: Core Agent
-    icon: ❌
+    icon: ✅
     module: bmm
 
   persona:

test/fixtures/agent-schema/valid/metadata/module-agent-missing-module.agent.yaml

@@ -0,0 +1,22 @@
+# Test: Module agent can omit module field
+# Expected: PASS
+# Note: Module field is optional
+
+agent:
+  metadata:
+    id: bmm-missing-module
+    name: No Module
+    title: Optional Module
+    icon: ✅
+
+  persona:
+    role: Test agent
+    identity: Test identity
+    communication_style: Test style
+    principles:
+      - Test principle
+
+  menu:
+    - trigger: help
+      description: Show help
+      action: display_help

test/fixtures/agent-schema/valid/metadata/wrong-module-value.agent.yaml

@@ -0,0 +1,23 @@
+# Test: Module agent can have any module value
+# Expected: PASS
+# Note: Module validation removed - agents can declare any module
+
+agent:
+  metadata:
+    id: wrong-module
+    name: Any Module
+    title: Any Module Value
+    icon: ✅
+    module: cis
+
+  persona:
+    role: Test agent
+    identity: Test identity
+    communication_style: Test style
+    principles:
+      - Test principle
+
+  menu:
+    - trigger: help
+      description: Show help
+      action: display_help