feat: enhance QA agent as senior developer with code review capabilities and major brownfield improvements

This release introduces significant enhancements across multiple areas:

QA Agent Transformation:
- Transform QA agent into senior developer role with active code refactoring abilities
- Add review-story task enabling QA to review, refactor, and improve code directly
- Integrate QA review step into standard development workflow (SM → Dev → QA)
- QA can fix small issues directly and leave checklist for remaining items
- Updated dev agent to maintain File List for QA review focus

Knowledge Base Improvements:
- Add extensive brownfield development documentation and best practices
- Clarify Web UI vs IDE usage with cost optimization strategies
- Document PRD-first approach for large codebases/monorepos
- Add comprehensive expansion packs explanation
- Update IDE workflow to include QA review step
- Clarify agent usage (bmad-master vs specialized agents)

Brownfield Enhancements:
- Create comprehensive Working in the Brownfield guide
- Add document-project task to analyst agent capabilities
- Implement PRD-first workflow option for focused documentation
- Transform document-project to create practical brownfield architecture docs
- Document technical debt, workarounds, and real-world constraints
- Reference actual files instead of duplicating content
- Add impact analysis when PRD is provided

Documentation Task Improvements:
- Simplify to always create ONE unified architecture document
- Add deep codebase analysis phase with targeted questions
- Focus on documenting reality including technical debt
- Include Quick Reference section with key file paths
- Add practical sections: useful commands, debugging tips, known issues

Workflow Updates:
- Update all 6 workflow files with detailed IDE transition instructions
- Add clear SM → Dev → QA → Dev cycle explanation
- Emphasize Gemini Web for brownfield analysis (1M+ context advantage)
- Support both PRD-first and document-first approaches

This release significantly improves the brownfield development experience and introduces a powerful shift-left QA approach with senior developer mentoring.
This commit is contained in:
Brian Madison
2025-06-24 23:56:57 -05:00
parent fb0be544ad
commit 3af3d33d4a
29 changed files with 4091 additions and 658 deletions

View File

@@ -101,7 +101,7 @@ This task guides you through creating a new BMAD agent following the standard te
## Prerequisites
- Agent template: `.bmad-core/templates/agent-tmpl.md`
- Agent template: `../templates/agent-tmpl.md`
- Target directory: `.bmad-core/agents/`
## Steps
@@ -318,7 +318,7 @@ Every expansion pack MUST include a custom BMAD orchestrator agent with sophisti
1. **Create Planning Document First**: Before any implementation, create a comprehensive plan for user approval
2. **Agent Architecture Standards**: Use YAML-in-Markdown structure with activation instructions, personas, and command systems
3. **Character Consistency**: Every agent must have a persistent persona with name, communication style, and numbered options protocol
3. **Character Consistency**: Every agent must have a persistent persona with name, communication style, and numbered options protocol similar to `expansion-packs/bmad-2d-phaser-game-dev/agents/game-designer.md`
4. **Custom Themed Orchestrator**: The orchestrator should embody the domain theme (e.g., Office Manager for medical, Project Lead for tech) for better user experience
5. **Core Utilities Required**: ALWAYS include these core files in every expansion pack:
- `tasks/create-doc.md` - Document creation from templates
@@ -326,8 +326,8 @@ Every expansion pack MUST include a custom BMAD orchestrator agent with sophisti
- `utils/template-format.md` - Template markup conventions
- `utils/workflow-management.md` - Workflow orchestration
6. **Team and Workflow Requirements**: If pack has >1 agent, MUST include:
- At least one team configuration in `agent-teams/`
- At least one workflow in `workflows/`
- At least one team configuration in `expansion-packs/{new-expansion}/agent-teams/`
- At least one workflow in `expansion-packs/{new-expansion}workflows/`
7. **Template Sophistication**: Implement LLM instruction embedding with `[[LLM: guidance]]`, conditional content, and variable systems
8. **Workflow Orchestration**: Include decision trees, handoff protocols, and validation loops
9. **Quality Assurance Integration**: Multi-level checklists with star ratings and ready/not-ready frameworks
@@ -1318,14 +1318,6 @@ Embedded knowledge (automatic):
- [ ] Template conditional content tested with different scenarios
- [ ] Workflow decision trees validated with sample use cases
- [ ] Character interactions tested for consistency and professional authenticity
```
```
```
```
==================== END: tasks#generate-expansion-pack ====================
==================== START: tasks#advanced-elicitation ====================